Fix Pages duplicating hash in redirects #6680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a287f4b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10820418885/npm-package-wrangler-6680You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6680/npm-package-wrangler-6680Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10820418885/npm-package-wrangler-6680 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10820418885/npm-package-create-cloudflare-6680 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10820418885/npm-package-cloudflare-kv-asset-handler-6680npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10820418885/npm-package-miniflare-6680npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10820418885/npm-package-cloudflare-pages-shared-6680npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10820418885/npm-package-cloudflare-vitest-pool-workers-6680npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10820418885/npm-package-cloudflare-workers-editor-shared-6680npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10820418885/npm-package-cloudflare-workers-shared-6680Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
WalshyDev
force-pushed
the
walshy/fix-hash-duping
branch
from
1f28622 to
3ad1dde
Compare
GregBrimble
reviewed
Sep 11, 2024
GregBrimble
approved these changes
Sep 11, 2024
WalshyDev
force-pushed
the
walshy/fix-hash-duping
branch
from
3ad1dde to
8acab3b
Compare
GregBrimble
reviewed
Sep 11, 2024
WalshyDev
force-pushed
the
walshy/fix-hash-duping
branch
2 times, most recently
from
b8c114e to
cf76229
Compare
WalshyDev
force-pushed
the
walshy/fix-hash-duping
branch
from
cf76229 to
a287f4b
Compare
Merged
andyjessop
added a commit
that referenced
this pull request
Sep 13, 2024
* main: Add pipeline binding to wrangler.toml (#6674) Fix Pages duplicating hash in redirects (#6680) Bradley/r2 event notification get (#6652) feat(wrangler): Add support for placement hints (#6625) fix(wrangler): Validate `routes` for Workers with assets (#6621) chore(deps): bump the workerd-and-workers-types group across 1 directory with 2 updates (#6673) chore(workers-shared): Configure GitHub Actions to deploy Asset Worker (#6542) feat: experimental workers assets can be ignored by adding a .assetsignore file (#6640)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test
Fixes CUSTESC-44240
Author has addressed the following