fix: delete unused [site] assets
#667
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2022271297/npm-package-wrangler-667You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/667/npm-package-wrangler-667Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2022271297/npm-package-wrangler-667 dev path/to/script.js |
threepointone
force-pushed
the
delete-unused-assets
branch
from
36ec090 to
206d319
Compare
🦋 Changeset detectedLatest commit: 641de33 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
It might be nice to add logging (in the future) to show what files are being upload, which are skipped and which are being deleted... |
|
we already log upload/skipping, I'll add a line for deleting too |
threepointone
force-pushed
the
delete-unused-assets
branch
2 times, most recently
from
88d2739 to
4f73251
Compare
|
Sorry my PR caused conflicts here @threepointone - let me know if you don't have time and I will do the rebase. |
|
no problemo, just one line, I got this |
We discovered critical issues with the way we expire unused assets with `[site]` (see #666, cloudflare/wrangler-legacy#2224), that we're going back to the legacy manner of handling unused assets, i.e- deleting unused assets. Fixes #666
threepointone
force-pushed
the
delete-unused-assets
branch
from
4f73251 to
641de33
Compare
We discovered critical issues with the way we expire unused assets with
[site](#666, cloudflare/wrangler-legacy#2224), that we're going back to the legacy manner of handling unused assets, i.e- deleting unused assets.Fixes #666