-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support analytics engine in local/remote dev #6666
Conversation
🦋 Changeset detectedLatest commit: 7a14484 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795874947/npm-package-wrangler-6666 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6666/npm-package-wrangler-6666 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795874947/npm-package-wrangler-6666 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795874947/npm-package-create-cloudflare-6666 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795874947/npm-package-cloudflare-kv-asset-handler-6666 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795874947/npm-package-miniflare-6666 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795874947/npm-package-cloudflare-pages-shared-6666 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795874947/npm-package-cloudflare-vitest-pool-workers-6666 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795874947/npm-package-cloudflare-workers-editor-shared-6666 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795874947/npm-package-cloudflare-workers-shared-6666 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
) => { | ||
// we're going to directly modify env so it maintains referential equality | ||
for (const binding of bindings) { | ||
env[binding] ??= bindingsEnv[binding]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes it so the binding doesn't get overridden if it's previously set. Now, AE actually does work in remote mode, which means it'll track events. There's an argument to be made here that we should mock it even then.
packages/wrangler/templates/middleware/middleware-mock-analytics-engine.ts
Outdated
Show resolved
Hide resolved
This adds "support" for analytics engine datasets for `wrangler dev`. Specifically, it simply mocks the AE bindings so that they exist while developing (and don't throw when accessed). This does NOT add support in Pages, though we very well could do so in a similar way in a followup.
015b14b
to
7a14484
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, Sunil!
This adds "support" for analytics engine datasets for
wrangler dev
. Specifically, it simply mocks the AE bindings so that they exist while developing (and don't throw when accessed).This does NOT add support in Pages, though we very well could do so in a similar way in a followup.
What this PR solves / how to test
Fixes #5532
Fixes #4383 (maybe?)
Author has addressed the following