-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename secret:bulk
top-level command to secret bulk
subcommand
#5988
Conversation
🦋 Changeset detectedLatest commit: f1e4d3b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9402783283/npm-package-wrangler-5988 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5988/npm-package-wrangler-5988 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9402783283/npm-package-wrangler-5988 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9402783283/npm-package-create-cloudflare-5988 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9402783283/npm-package-cloudflare-kv-asset-handler-5988 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9402783283/npm-package-miniflare-5988 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9402783283/npm-package-cloudflare-pages-shared-5988 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9402783283/npm-package-cloudflare-vitest-pool-workers-5988 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
should we mark https://github.com/cloudflare/workers-sdk/blob/main/packages/wrangler/src/index.ts#L399-L404 as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! KV next..?
and deprecate `secret:bulk` Fixes #5168
434c0eb
to
f1e4d3b
Compare
and deprecate
secret:bulk
– command still exists with same functionality but also with a deprecation noticeFixes #5168
What this PR solves / how to test
Fixes #[insert GH or internal issue number(s)].
Author has addressed the following