feat: dev+envs #532
Merged
feat: dev+envs #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b3654be The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/1924516548/npm-package-wrangler-532You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/532/npm-package-wrangler-532Or you can use npx https://prerelease-registry.developers.workers.dev/runs/1924516548/npm-package-wrangler-532 dev path/to/script.js |
threepointone
force-pushed
the
dev-envs
branch
from
dd5fa5a to
fe5a9d9
Compare
petebacondarwin
approved these changes
Mar 2, 2022
There was a problem hiding this comment.
This all looks like it should work, although I have not run it locally :-)
There doesn't seem to be much point in separate CfAccount and CfWorkerContext interfaces any more. They are always used as a pair, AFAICT. So how about just join them up into a single CfWorkerContext interface?
This implements service environments + `wrangler dev`. Fairly simple, it just needed the right url when creating the edge preview token. I tested this by publishing a service under one env, adding secrets under it in the dashboard, and then trying to dev under another env, and verifying that the secrets didn't leak.
|
Agreed about the type, and I'll merge the CfAccount and CfWorkerContext types in a followup PR. |
Merged
mrbbot
added a commit
that referenced
this pull request
Oct 31, 2023
Wait for control messages using the new `--control-fd` flag for signalling when `workerd` is ready to receive requests, and the port it's listening on. This allows us to pass port `0` directly to workerd, and have it allocate a free port, preventing races. It also allows us to remove the repeated readiness probes. 🎉
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
Wait for control messages using the new `--control-fd` flag for signalling when `workerd` is ready to receive requests, and the port it's listening on. This allows us to pass port `0` directly to workerd, and have it allocate a free port, preventing races. It also allows us to remove the repeated readiness probes. 🎉
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
Wait for control messages using the new `--control-fd` flag for signalling when `workerd` is ready to receive requests, and the port it's listening on. This allows us to pass port `0` directly to workerd, and have it allocate a free port, preventing races. It also allows us to remove the repeated readiness probes. 🎉
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
Wait for control messages using the new `--control-fd` flag for signalling when `workerd` is ready to receive requests, and the port it's listening on. This allows us to pass port `0` directly to workerd, and have it allocate a free port, preventing races. It also allows us to remove the repeated readiness probes. 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements service environments +
wrangler dev. Fairly simple, it just needed the right url when creating the edge preview token.I tested this by publishing a service under one env, adding secrets under it in the dashboard, and then trying to dev under another env, and verifying that the secrets didn't leak.
(This uncovered an issue where we can't set the right host incl. the env prefix, but it's not critical right now, following up internally.)