-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wrangler] fix: require worker name for rollback #4588
Conversation
🦋 Changeset detectedLatest commit: b86926f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7291004825/npm-package-wrangler-4588 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7291004825/npm-package-wrangler-4588 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7291004825/npm-package-wrangler-4588 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7291004825/npm-package-miniflare-4588 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7291004825/npm-package-cloudflare-pages-shared-4588 npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7291004825/npm-package-create-cloudflare-4588 --no-auto-update Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4588 +/- ##
==========================================
+ Coverage 75.16% 75.22% +0.05%
==========================================
Files 242 242
Lines 13014 13017 +3
Branches 3346 3346
==========================================
+ Hits 9782 9792 +10
+ Misses 3232 3225 -7
|
ac1e543
to
b86926f
Compare
Fixes #3372.
What this PR solves / how to test:
Previously, Wrangler would fail with a cryptic error if you tried to run
wrangler rollback
outside of a directory containing a Wrangler configuration file with aname
defined. This change validates that a worker name is defined, and allows you to set it from the command line using the--name
flag. To test this, try to runwrangler rollback
in a directory without awrangler.toml
. This should fail, but runningwrangler rollback --name <NAME_TO_VALID_WORKER>
should succeed.Author has addressed the following:
wrangler rollback --name
flag cloudflare-docs#12204Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.