Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wrangler] fix: require worker name for rollback #4588

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

mrbbot
Copy link
Contributor

@mrbbot mrbbot commented Dec 12, 2023

Fixes #3372.

What this PR solves / how to test:

Previously, Wrangler would fail with a cryptic error if you tried to run wrangler rollback outside of a directory containing a Wrangler configuration file with a name defined. This change validates that a worker name is defined, and allows you to set it from the command line using the --name flag. To test this, try to run wrangler rollback in a directory without a wrangler.toml. This should fail, but running wrangler rollback --name <NAME_TO_VALID_WORKER> should succeed.

Author has addressed the following:

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@mrbbot mrbbot requested a review from a team as a code owner December 12, 2023 14:13
Copy link

changeset-bot bot commented Dec 12, 2023

🦋 Changeset detected

Latest commit: b86926f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 12, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7291004825/npm-package-wrangler-4588

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7291004825/npm-package-wrangler-4588

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7291004825/npm-package-wrangler-4588 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7291004825/npm-package-miniflare-4588
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7291004825/npm-package-cloudflare-pages-shared-4588
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7291004825/npm-package-create-cloudflare-4588 --no-auto-update

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.22.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231030.4
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4864013) 75.16% compared to head (b86926f) 75.22%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4588      +/-   ##
==========================================
+ Coverage   75.16%   75.22%   +0.05%     
==========================================
  Files         242      242              
  Lines       13014    13017       +3     
  Branches     3346     3346              
==========================================
+ Hits         9782     9792      +10     
+ Misses       3232     3225       -7     
Files Coverage Δ
.../src/__tests__/helpers/msw/handlers/deployments.ts 75.86% <100.00%> (+2.78%) ⬆️
packages/wrangler/src/deployments.ts 76.19% <100.00%> (ø)
packages/wrangler/src/index.ts 89.04% <ø> (ø)

... and 7 files with indirect coverage changes

@petebacondarwin petebacondarwin force-pushed the bcoll/rollback-require-name branch from ac1e543 to b86926f Compare December 21, 2023 16:55
@petebacondarwin petebacondarwin merged commit 4e5ed0b into main Dec 22, 2023
17 checks passed
@petebacondarwin petebacondarwin deleted the bcoll/rollback-require-name branch December 22, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve messaging around wrangler rollback not being able to find a worker
3 participants