Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C3: Disable astro e2e for npm #4290

Merged
merged 2 commits into from
Oct 27, 2023
Merged

C3: Disable astro e2e for npm #4290

merged 2 commits into from
Oct 27, 2023

Conversation

dario-piotrowicz
Copy link
Member

Not ideal but the Cloudflare Astro adapter is currently broken when used with npm.

We're looking into fixing this upstream, in the meantime I am disabling the astro npm e2e test so that we can at least keep using the e2e CI checks in the meantime.

@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner October 27, 2023 16:12
@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2023

⚠️ No Changeset found

Latest commit: 774686e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #4290 (774686e) into main (a027b57) will increase coverage by 0.04%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4290      +/-   ##
==========================================
+ Coverage   75.39%   75.43%   +0.04%     
==========================================
  Files         223      223              
  Lines       12330    12327       -3     
  Branches     3186     3187       +1     
==========================================
+ Hits         9296     9299       +3     
+ Misses       3034     3028       -6     

see 7 files with indirect coverage changes

@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6669634374/npm-package-wrangler-4290

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6669634374/npm-package-wrangler-4290

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6669634374/npm-package-wrangler-4290 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6669634374/npm-package-cloudflare-pages-shared-4290

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.15.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare 3.20231025.0 3.20231025.0
workerd 1.20231025.0 1.20231025.0
workerd --version 1.20231025.0 2023-10-25

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@dario-piotrowicz dario-piotrowicz merged commit 47b0b0e into main Oct 27, 2023
@dario-piotrowicz dario-piotrowicz deleted the quarantine-astro branch October 27, 2023 17:40
dario-piotrowicz added a commit that referenced this pull request Oct 27, 2023
dario-piotrowicz added a commit that referenced this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants