Fix wrangler dev --local and its lazy imports of @miniflare/tre
#2339
Conversation
🦋 Changeset detectedLatest commit: 7d27528 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/runs/3628661494/npm-package-wrangler-2339You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/prs/2339/npm-package-wrangler-2339Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/runs/3628661494/npm-package-wrangler-2339 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/runs/3628661494/npm-package-cloudflare-pages-shared-2339 |
Codecov Report
@@ Coverage Diff @@
## main #2339 +/- ##
==========================================
+ Coverage 70.78% 70.82% +0.03%
==========================================
Files 152 152
Lines 9712 9711 -1
Branches 2536 2536
==========================================
+ Hits 6875 6878 +3
+ Misses 2837 2833 -4
|
| await readyPromise; | ||
| await new Promise((resolve, reject) => { | ||
| wranglerProcess.once("exit", (code) => { | ||
| if (!code) { |
There was a problem hiding this comment.
Nit: code will be null if the process is terminated with a signal, in which case we'd want to reject.
| if (!code) { | |
| if (code === 0) { |
| afterAll(async () => { | ||
| await readyPromise; | ||
| await new Promise((resolve, reject) => { | ||
| wranglerProcess.once("exit", (code) => { |
There was a problem hiding this comment.
Not required, but you might want to consider using the once helper from node:events here.
|
|
The
await import()of the environment polyfills seemed to break out of theif (tre) {}check. This made theminiflare-clidist look like:When the
@miniflare/trepackage was missing, this brokewrangler dev --localfor users.By wrapping the polyfill logic in a function like this, we can avoid this top-level import.