Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: name shouldn't be defined in environments if legacy_env = false #623

Closed
threepointone opened this issue Mar 17, 2022 · 0 comments · Fixed by #641 or #562
Closed

fix: name shouldn't be defined in environments if legacy_env = false #623

threepointone opened this issue Mar 17, 2022 · 0 comments · Fixed by #641 or #562
Assignees
@petebacondarwin

Comments

@threepointone
Copy link
Contributor

With the new experimental service environments (not released yet, don't use), we shouldn't override the name of the script inside environments, since they have to all be grouped as one on the dashboard. So it should probably be an error.
petebacondarwin added a commit to petebacondarwin/wrangler2 that referenced this issue Mar 18, 2022
@petebacondarwin
fix: error if a non-legacy service environment tries to define a work…
f67e191 
…er name

Given that service environments all live off the same worker, it doesn't make sense
for them to have different names.

This change adds validation to tell the developer to remove such `name` fields in
service environment config.

Fixes cloudflare#623
@petebacondarwin petebacondarwin mentioned this issue Mar 18, 2022
Merged
@petebacondarwin petebacondarwin self-assigned this Mar 18, 2022
@petebacondarwin petebacondarwin moved this to In Review in workers-sdk Mar 18, 2022
petebacondarwin added a commit to petebacondarwin/wrangler2 that referenced this issue Mar 18, 2022
@petebacondarwin
fix: error if a non-legacy service environment tries to define a work…
af0943a 
…er name

Given that service environments all live off the same worker, it doesn't make sense
for them to have different names.

This change adds validation to tell the developer to remove such `name` fields in
service environment config.

Fixes cloudflare#623
@petebacondarwin petebacondarwin added this to the 2.0 milestone Mar 19, 2022
petebacondarwin added a commit to petebacondarwin/wrangler2 that referenced this issue Mar 19, 2022
@petebacondarwin
fix: error if a non-legacy service environment tries to define a work…
26d181f 
…er name

Given that service environments all live off the same worker, it doesn't make sense
for them to have different names.

This change adds validation to tell the developer to remove such `name` fields in
service environment config.

Fixes cloudflare#623
petebacondarwin added a commit to petebacondarwin/wrangler2 that referenced this issue Mar 19, 2022
@petebacondarwin
fix: error if a non-legacy service environment tries to define a work…
1d41b8a 
…er name

Given that service environments all live off the same worker, it doesn't make sense
for them to have different names.

This change adds validation to tell the developer to remove such `name` fields in
service environment config.

Fixes cloudflare#623
petebacondarwin added a commit that referenced this issue Mar 20, 2022
@petebacondarwin
fix: error if a non-legacy service environment tries to define a work…
21ee93e 
…er name

Given that service environments all live off the same worker, it doesn't make sense
for them to have different names.

This change adds validation to tell the developer to remove such `name` fields in
service environment config.

Fixes #623
Repository owner moved this from In Review to Done in workers-sdk Mar 20, 2022
@github-actions github-actions bot mentioned this issue Mar 20, 2022
Merged
mrbbot pushed a commit that referenced this issue Oct 31, 2023
@penalosa @mrbbot
Bump workerd version (#623)
b24b562 
* bump workerd version

* change nodeJS version
mrbbot pushed a commit that referenced this issue Nov 1, 2023
@penalosa @mrbbot
Bump workerd version (#623)
f3e4155 
* bump workerd version

* change nodeJS version
mrbbot pushed a commit that referenced this issue Nov 1, 2023
@penalosa @mrbbot
Bump workerd version (#623)
d81749a 
* bump workerd version

* change nodeJS version
mrbbot pushed a commit that referenced this issue Nov 1, 2023
@penalosa @mrbbot
Bump workerd version (#623)
418429f 
* bump workerd version

* change nodeJS version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petebacondarwin petebacondarwin

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@petebacondarwin @threepointone