UX Bug in wrangler dev

[Warfields]

The prompt box for wrangler dev's tools is a bit glitchy as seen below

How to reproduce

1. wrangle dev <wrong_path_to_src>
2. repeatedly press L

[Warfields]

This appears to only be an issue when you mistype the path, not sure if we even should care about this now. Previously I thought it always appeared when starting and stoping miniflare.

[threepointone]

If we have a wrong path to src, we should simply quit the process with an error message. (We should do the check after useCustomBuild returns in dev, and after running config.build.command in publish, because that may be the logic that generates the file).

[threepointone]

Ok, I see we fail for publish, but in dev we just catch the error and leave the process running. We should end the process immediately.

[Warfields]

I looked into the code and found this, it appears that we caught the build errors for a reason. I think it's so that when --watch is used we don't immediately kill the process, we could add a conditional if watch is not present to kill on line 507.

[Warfields]

Further digging, by default the code uses --watch on all ESBuilds. So we might want to watch for the not resolving error specifically, but I am not sure if a file with an error in it would raise the same error.

[petebacondarwin]

Is an invalid entry-point unrecoverable? I.e. what if we renamed the entry-point (causing the build to break) and then renamed it back again? If so, then perhaps we should not exit but instead just make sure that the UI doesn't get corrupted.

[Warfields]

Yeah, that's what I'm thinking about too.

…

On Wed, Jan 26, 2022 at 12:33 PM Pete Bacon Darwin ***@***.***> wrote: Is an invalid entry-point unrecoverable? I.e. what if we renamed the entry-point (causing the build to break) and then renamed it back again? If so, then perhaps we should not exit but instead just make sure that the UI doesn't get corrupted. — Reply to this email directly, view it on GitHub <#308 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AH3SDLCVMDITFNFX3KLBXUTUYBEALANCNFSM5M2CYABQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[threepointone]

It's very unlikely that an entry point would get renamed. We can work on that usecase, but seems like overkill to design around that. In this scenario, it doesn't exist on the first run itself, and we should probably exit immediately imo.

[threepointone]

Fixed by #455