Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 BUG: wrangler dev --experimental-local doesn't cleanly shut down the server #2387

Closed
IgorMinar opened this issue Dec 10, 2022 · 0 comments · Fixed by #2400
Closed

🐛 BUG: wrangler dev --experimental-local doesn't cleanly shut down the server #2387

IgorMinar opened this issue Dec 10, 2022 · 0 comments · Fixed by #2400
Labels
bug Something that isn't working

Comments

@IgorMinar
Copy link
Contributor

What version of Wrangler are you using?

2.6.2

What operating system are you using?

Mac

Describe the Bug

wrangler dev --experimental-local                                                                          (master|…6)
 ⛅️ wrangler 2.6.2 
-------------------
workerd/server/server.c++:2138: info: Inspector is listening
[mf:inf] Ready on http://127.0.0.1:8787/
workerd/server/server.c++:967: info: Inspector client attaching [core:user:workers-hot]
╭───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ [b] open a browser, [d] open Devtools, [l] turn off local mode, [c] clear console, [x] to exit                                                │
╰───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
⎔ Shutting down experimental local server.

When I hit q or ctrl+c, I see Shutting down experimental local server. but the wrangler process never exists on its own. I have to either kill the process or hit ctrl+c again.
@IgorMinar IgorMinar added the bug Something that isn't working label Dec 10, 2022
mrbbot added a commit that referenced this issue Dec 13, 2022
@mrbbot
Allow --experimental-local to cleanly exit on x/CTRL-C
da086a2 
In the bootstrapper script `bin/wrangler.js`, we open an IPC channel,
so IPC messages from the Wrangler process are propagated through the
bootstrapper. Normally, Node's SIGINT handler would close this for
us, but interactive mode enables raw mode on stdin which disables the
built-in handler. This PR calls `process.disconnect()` to close this
channel when we press `x` or CTRL-C, ensuring no open handles, and
allowing for a clean exit.

Closes #2387
@mrbbot mrbbot mentioned this issue Dec 13, 2022
Merged
6 tasks
mrbbot added a commit that referenced this issue Dec 15, 2022
@mrbbot
Allow --experimental-local to cleanly exit on x/CTRL-C (#2400)
08a0b22 
* Allow `--experimental-local` to cleanly exit on `x`/`CTRL-C`

In the bootstrapper script `bin/wrangler.js`, we open an IPC channel,
so IPC messages from the Wrangler process are propagated through the
bootstrapper. Normally, Node's SIGINT handler would close this for
us, but interactive mode enables raw mode on stdin which disables the
built-in handler. This PR calls `process.disconnect()` to close this
channel when we press `x` or CTRL-C, ensuring no open handles, and
allowing for a clean exit.

Closes #2387

* fixup! Allow `--experimental-local` to cleanly exit on `x`/`CTRL-C`

* fixup! fixup! Allow `--experimental-local` to cleanly exit on `x`/`CTRL-C`

* fixup! Allow `--experimental-local` to cleanly exit on `x`/`CTRL-C`
@mrbbot mrbbot mentioned this issue Dec 19, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something that isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow --experimental-local to cleanly exit on x/CTRL-C cloudflare/workers-sdk
1 participant
@IgorMinar