Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish: On 10000/ auth errors, we should log details about the token #1197

Closed
threepointone opened this issue Jun 7, 2022 · 3 comments · Fixed by #3926
Closed

polish: On 10000/ auth errors, we should log details about the token #1197

threepointone opened this issue Jun 7, 2022 · 3 comments · Fixed by #3926
Assignees
Labels
polish Small improvements to the experience

Comments

@threepointone
Copy link
Contributor

A significant number of bug reports/issues are about auth and tokens and stuff. While there are bugs that we should fix, some of it is just configuration. So when wrangler fails with a 10000 error, we should log details related to the token so it's easier to debug/report. (api for getting permission groups: https://api.cloudflare.com/#permission-groups-list-permission-groups)

@threepointone threepointone added the polish Small improvements to the experience label Jun 7, 2022
@threepointone threepointone moved this to Untriaged in workers-sdk Jun 7, 2022
@petebacondarwin
Copy link
Contributor

This is very similar to (perhaps even a duplicate of) #761.

@threepointone
Copy link
Contributor Author

threepointone commented Jun 7, 2022

Mmmm maybe related. This one is about logging more details, that one is about suggesting a relogin. Maybe both will be useful

@petebacondarwin petebacondarwin moved this from Untriaged to Selected for development in workers-sdk Jun 7, 2022
@JacobMGEvans
Copy link
Contributor

A significant number of bug reports/issues are about auth and tokens and stuff. While there are bugs that we should fix, some of it is just configuration. So when wrangler fails with a 10000 error, we should log details related to the token so it's easier to debug/report. (api for getting permission groups: https://api.cloudflare.com/#permission-groups-list-permission-groups)

Is this referring to the instance of people having a token that doesn't have correct permissions somewhere not getting information necessary, I remember someone had mentioned showing the token and some additional information from the permissions error. I don't remember that scenario completely, but it may help to know it to differentiate the work in issue 761

@lrapoport-cf lrapoport-cf moved this from Selected for Development to Backlog in workers-sdk Sep 7, 2022
@penalosa penalosa self-assigned this Sep 11, 2023
penalosa added a commit that referenced this issue Sep 11, 2023
penalosa added a commit that referenced this issue Sep 11, 2023
penalosa added a commit that referenced this issue Oct 2, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in workers-sdk Oct 2, 2023
dario-piotrowicz pushed a commit that referenced this issue Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
polish Small improvements to the experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants