fix: ensure API failures without messages logged correctly (#4695)

.changeset/fifty-crabs-flow.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+fix: ensure API failures without additional messages logged correctly

packages/wrangler/src/__tests__/cfetch-utils.test.ts

@@ -78,4 +78,22 @@ describe("throwFetchError", () => {
 			],
 		});
 	});
+
+	it("should include api errors without messages", async () => {
+		msw.use(
+			rest.get("*/user", (req, res, ctx) => {
+				return res(
+					ctx.json({
+						result: null,
+						success: false,
+						errors: [{ code: 10000, message: "error" }],
+					})
+				);
+			})
+		);
+		await expect(runWrangler("whoami")).rejects.toMatchObject({
+			text: "A request to the Cloudflare API (/user) failed.",
+			notes: [{ text: "error [code: 10000]" }],
+		});
+	});
 });

packages/wrangler/src/cfetch/index.ts

@@ -13,7 +13,7 @@ export interface FetchResult<ResponseType = unknown> {
 	success: boolean;
 	result: ResponseType;
 	errors: FetchError[];
-	messages: string[];
+	messages?: string[];
 	result_info?: unknown;
 }
 
@@ -168,7 +168,7 @@ function throwFetchError(
 		text: `A request to the Cloudflare API (${resource}) failed.`,
 		notes: [
 			...response.errors.map((err) => ({ text: renderError(err) })),
-			...response.messages.map((text) => ({ text })),
+			...(response.messages?.map((text) => ({ text })) ?? []),
 		],
 	});
 	// add the first error code directly to this error