Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Python package vendoring work #3632

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Make Python package vendoring work #3632

merged 2 commits into from
Feb 28, 2025

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Feb 28, 2025

  • Python: Clean up pyodide.h a bit
    This removes the no longer used APIs and moves more functions to PythonModuleInfo.

  • Python: Update getPackageSnapshotImports() to handle vendor directory
    This adds vendor directory handling to getPackageSnapshotImports() and so makes package vendoring work correctly.

@hoodmane hoodmane requested review from a team as code owners February 28, 2025 16:13
This removes the no longer used APIs and moves more functions to PythonModuleInfo.
@hoodmane hoodmane force-pushed the hoodmane/vendor-full branch 2 times, most recently from ed571b9 to af37d0e Compare February 28, 2025 16:55
@hoodmane hoodmane changed the title Python: Clean up pyodide.h a bit Make Python package vendoring work Feb 28, 2025
@hoodmane hoodmane force-pushed the hoodmane/vendor-full branch 3 times, most recently from a6cb098 to 43af23b Compare February 28, 2025 17:22
@hoodmane hoodmane requested a review from dom96 February 28, 2025 17:24
Copy link
Collaborator

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits but otherwise LGTM

@hoodmane hoodmane force-pushed the hoodmane/vendor-full branch 2 times, most recently from a7a65bd to 042ffd1 Compare February 28, 2025 17:38
This adds vendor directory handling to getPackageSnapshotImports() and
by doing so makes package vendoring work correctly.
@hoodmane hoodmane force-pushed the hoodmane/vendor-full branch from 042ffd1 to bf4cc6f Compare February 28, 2025 17:47
@hoodmane hoodmane merged commit 73abe94 into main Feb 28, 2025
16 of 17 checks passed
@hoodmane hoodmane deleted the hoodmane/vendor-full branch February 28, 2025 19:49
anonrig pushed a commit that referenced this pull request Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants