Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify node:net types #3619

Merged
merged 1 commit into from
Feb 27, 2025
Merged

simplify node:net types #3619

merged 1 commit into from
Feb 27, 2025

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Feb 26, 2025 •
edited
Loading

Simplifies the types. Currently it throws a compile error which I'm trying to solve.

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
src/node/net.ts(120,22): error TS2323: Cannot redeclare exported variable 'Socket'.
src/node/net.ts(198,17): error TS2323: Cannot redeclare exported variable 'Socket'.

@anonrig anonrig requested review from a team as code owners February 26, 2025 21:51
@anonrig anonrig requested review from ketanhwr, npaun and mikea February 26, 2025 21:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 26, 2025 •
edited
Loading

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@anonrig anonrig force-pushed the yagiz/simplify-node-net-types branch from 1c58838 to a7473c2 Compare February 27, 2025 00:21
@anonrig anonrig merged commit 13b8ec7 into main Feb 27, 2025
17 checks passed
@anonrig anonrig deleted the yagiz/simplify-node-net-types branch February 27, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@ketanhwr ketanhwr Awaiting requested review from ketanhwr ketanhwr is a code owner automatically assigned from cloudflare/workers-runtime-1

@npaun npaun Awaiting requested review from npaun npaun is a code owner automatically assigned from cloudflare/workers-runtime-1

@mikea mikea Awaiting requested review from mikea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anonrig @jasnell