Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Make new C++ function getPackageSnapshotImports #3608

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

hoodmane
Copy link
Contributor

This simplifies our life when we have to adjust the logic for what goes into the package snapshots. For now leave the old functions to make it easier to migrate.

@hoodmane hoodmane requested review from a team as code owners February 26, 2025 15:51
@hoodmane hoodmane added the python Issues/PRs relating to Python Workers label Feb 26, 2025
@hoodmane hoodmane requested a review from dom96 February 26, 2025 15:51
@hoodmane hoodmane force-pushed the hoodmane/get-package-snapshot-imports branch from 0c969b8 to 54e0924 Compare February 26, 2025 15:56
Copy link

github-actions bot commented Feb 26, 2025

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

This simplifies our life when we have to adjust the logic for what
goes into the package snapshots. For now leave the old functions to
make it easier to migrate.
@hoodmane hoodmane force-pushed the hoodmane/get-package-snapshot-imports branch from 54e0924 to 977b52f Compare February 26, 2025 17:37
@hoodmane hoodmane changed the title Python: Make new C++ functiong getPackageSnapshotImports Python: Make new C++ function getPackageSnapshotImports Feb 26, 2025
@hoodmane hoodmane merged commit c97c8a6 into main Feb 27, 2025
15 of 17 checks passed
@hoodmane hoodmane deleted the hoodmane/get-package-snapshot-imports branch February 27, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Issues/PRs relating to Python Workers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants