[nfc] Disentangle and Modularize JSG #3607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
reviewed
Feb 26, 2025
- Factor several files out of the main JSG target - Significantly reduce header interdependencies/cycles - Start splitting up uses of <v8.h> into constituent headers. This will make future refactoring of JSG easier.
fhanau
force-pushed
the
felix/022425-jsg-disentangle
branch
from
1a22071 to
82d971b
Compare
fhanau
changed the title
anonrig
approved these changes
Feb 26, 2025
jasnell
approved these changes
Feb 26, 2025
|
Wasn't sure if this was possible at all, but looks like it "just works"! Apparently downstream changes are not required. I want to reduce exposure to the expansive JSG API (and by extension V8 headers) for dependent code in the future, this will certainly make it easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make future refactoring of JSG easier.