Add Response.prototype.type property #3590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/fetch-response-type
branch
from
cebf528 to
ac4b5d8
Compare
anonrig
approved these changes
Feb 22, 2025
This was referenced Feb 22, 2025
jasnell
force-pushed
the
jasnell/fetch-response-type
branch
from
ac4b5d8 to
307d264
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/fetch-response-type
branch
from
307d264 to
ca052c4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
reviewed
Feb 22, 2025
|
The generated output of |
anonrig
approved these changes
Feb 24, 2025
WinterTC recently agreed that conformant implementations should, at the very least, support the `'default'` value for `Response.prototype.type` property and, if the runtime implements `Response.error()`, the `'error'` value -- even if the implementation otherwise does not implement CORS.
jasnell
force-pushed
the
jasnell/fetch-response-type
branch
from
75653f2 to
672a70c
Compare
jasnell
commented
Feb 24, 2025
jasnell
commented
Feb 24, 2025
jasnell
commented
Feb 24, 2025
jasnell
commented
Feb 24, 2025
jasnell
commented
Feb 24, 2025
jasnell
commented
Feb 24, 2025
|
@irvinebroque ... for the changelog entry once this and #3592 are merged and are released: We are adding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WinterTC recently agreed that conformant implementations should, at the very least, support the
'default'value forResponse.prototype.typeproperty and, if the runtime implementsResponse.error(), the'error'value -- even if the implementation otherwise does not implement CORS.