Expose cpu and wall time in TraceItem #3585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Feb 21, 2025
zebp
force-pushed
the
zeb/trace-worker-metrics
branch
from
053ef66 to
4b44c8a
Compare
anonrig
approved these changes
Feb 21, 2025
zebp
force-pushed
the
zeb/trace-worker-metrics
branch
from
4b44c8a to
5d66722
Compare
anonrig
approved these changes
Feb 24, 2025
zebp
force-pushed
the
zeb/trace-worker-metrics
branch
from
5d66722 to
297f933
Compare
zebp
force-pushed
the
zeb/trace-worker-metrics
branch
3 times, most recently
from
9b6776c to
10dfcc6
Compare
Exposes CPU/Wall time in the trace workers api instead of hiding it behind the UnsafeTraceMetrics binding now that we have the confidence we can safely expose this without any spectre issues.
zebp
force-pushed
the
zeb/trace-worker-metrics
branch
from
10dfcc6 to
94a8360
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal PR: #9943
Exposes CPU/Wall time in the trace workers api instead of hiding it behind the UnsafeTraceMetrics binding now that we have the confidence we can safely expose this without any spectre issues.