-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be able to pass environment variables in containers start() #3575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentonv
reviewed
Feb 20, 2025
40b8e4c
to
7a71bd5
Compare
7a71bd5
to
462996c
Compare
b02c9f0
to
76b08c0
Compare
kentonv
reviewed
Feb 24, 2025
kentonv
reviewed
Feb 24, 2025
76b08c0
to
b5008e1
Compare
kentonv
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but you need to run the formatter.
dd9ec74
to
3c2666e
Compare
rebased |
3c2666e
to
9f1f107
Compare
9f1f107
to
f188779
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are just defining in the container capnp schema the
environmentVariables
property, and theenv
property in the start options.The user will be able to pass environment variables like this:
If the container image is already configured to have
A=C
, it will override it and setA
toB
. New environment variables are just appended. It's up to the container runtime to implement this behaviour correctly.