CACHE-12946: add compatibility flag to override cache rules via cache… #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
yj7o5
force-pushed
the
yawar/CACHE-12046_ew-cf-api-override
branch
from
7dadfca to
6d52401
Compare
|
recheck |
jasnell
approved these changes
Feb 15, 2025
|
recheck |
danlapid
requested changes
Feb 24, 2025
danlapid
requested changes
Feb 24, 2025
danlapid
requested changes
Feb 24, 2025
yj7o5
force-pushed
the
yawar/CACHE-12046_ew-cf-api-override
branch
from
0d0a0d4 to
9f920c1
Compare
yj7o5
force-pushed
the
yawar/CACHE-12046_ew-cf-api-override
branch
from
9f920c1 to
6d52401
Compare
yj7o5
force-pushed
the
yawar/CACHE-12046_ew-cf-api-override
branch
from
6d52401 to
f3c9248
Compare
|
sorry @danlapid fixed now, also can this please be approved and merged now? this PRs been sitting in the queue for almost 2 weeks now? |
danlapid
approved these changes
Feb 25, 2025
|
@danlapid is there a way to run these workflows? I don't know status are they waiting for to be reported on ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #3342 adding a new compatibility flag to allow overriding cache rules via the request.cf object that can be specified on the
cache.put(Request)API.Currently, if a resource is PUT via the cache API and have cache settings such as cacheEverything: true specified in the 'cf' object, while there is also cache rules defined against that resource, the cache settings in request cf object isn't respected. Cache team is working on fixing this behavior to give precedence over to request cf object first and then to cache rules, however, we are hiding this behavior behind a compatibility flag until we're confident the change works as intended for everyone.