Fixup the streaming tail worker implementation #3539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhanau
reviewed
Feb 19, 2025
fhanau
reviewed
Feb 19, 2025
fhanau
reviewed
Feb 19, 2025
fhanau
reviewed
Feb 19, 2025
jasnell
commented
Feb 20, 2025
|
@fhanau ... once this passes internal CI, I'll do a final review on the parts you added/modified. |
fhanau
force-pushed
the
jasnell/moar-streaming-tail-worker
branch
from
61cdeeb to
aaf7cc4
Compare
|
@fhanau ... I cannot sign off on my own PR but your updates LGTM. |
* Fixes UAF in server.c++ handling * Simplifies trace-stream implementation * Ensures that the outcome event is sent in fetch request traces * Still needs to ensure that outcome is sent in all other types of invocations * Still needs tests, tests, and more tests. * Tests to verify that throwing an error in the tail worker handler works as expected * Tests to verify that all of the various ways a worker invocation can complete will appropriately trigger an outcome event * Tests to verify that all internal state is cleaned up and not leaked
…most event types, initial testing
fhanau
force-pushed
the
jasnell/moar-streaming-tail-worker
branch
from
aaf7cc4 to
2f42300
Compare
fhanau
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fhanau .... opening this as a draft and handing it over to you for next steps..