Refactor to use C++ implementation of requirement gathering for Python. #3538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dom96
requested review from
a-robinson,
ObsidianMinor,
hoodmane and
danlapid
|
The generated output of |
danlapid
reviewed
Feb 13, 2025
danlapid
reviewed
Feb 13, 2025
danlapid
reviewed
Feb 13, 2025
danlapid
reviewed
Feb 13, 2025
dom96
force-pushed
the
dominik/refactor-req-gathering
branch
2 times, most recently
from
d220ed6 to
f8e3ebd
Compare
jasnell
reviewed
Feb 14, 2025
dom96
force-pushed
the
dominik/refactor-req-gathering
branch
2 times, most recently
from
d4c389e to
3895bf9
Compare
|
For now I've reverted back to using an Array, let's get this merged in and we can use a HashSet later if we agree on merging #3550. |
hoodmane
reviewed
Feb 20, 2025
Wasn't following too closely but it seems like you do have agreement on merging that 🤔 |
hoodmane
reviewed
Feb 20, 2025
hoodmane
approved these changes
Feb 20, 2025
Potentially yes, but no approval on the PR as of yet. |
dom96
force-pushed
the
dominik/refactor-req-gathering
branch
3 times, most recently
from
34a1e08 to
1bf6779
Compare
dom96
force-pushed
the
dominik/refactor-req-gathering
branch
from
1bf6779 to
5588d13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current state of things is that the logic for gathering package requirements is duplicated in TS and C++. This PR moves it into workerd so that the same implementation can be used in workerd and EW.