provider: update internal logging sink to use cloudflare-go logger #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of cloudflare/cloudflare-go#1164 we have the ability to use the inbuilt logger for redacting sensitive HTTP headers. Previously, we were discarding the provided logger due to instantiating a new `cleanhttp` client to use however, with this change we are now using the cloudflare-go logger for HTTP interactions inside the Terraform Core sink. By default we redact the values found in the following HTTP headers (not the headers themselves) in the entire HTTP interaction: - `X-Auth-Email` - `X-Auth-Key` - `X-Auth-User-Service-Key` - `Authorization` And here is an example of the logger in action for `TF_LOG=DEBUG`. ``` 2023-01-05T06:49:41.208221+11:00 [DEBUG] cloudflare GET /client/v4/zones/0da42c8d2132a9ddaf714f9e7c920711/access/apps/dec500cc-4eb3-4c64-b10d-1fce8f686339 HTTP/1.1 Host: api.cloudflare.com User-Agent: terraform/1.3.6 terraform-plugin-sdk/2.10.1 terraform-provider-cloudflare/dev Content-Type: application/json X-Auth-Email: [redacted] X-Auth-Key: [redacted] Accept-Encoding: gzip 2023-01-05T06:49:41.208221+11:00 [DEBUG] cloudflare HTTP/1.1 200 OK Transfer-Encoding: chunked Cf-Cache-Status: DYNAMIC Cf-Ray: 78467fb52e4baaf9-SYD Connection: keep-alive ... { "result": { "id": "dec500cc-4eb3-4c64-b10d-1fce8f686339", "uid": "dec500cc-4eb3-4c64-b10d-1fce8f686339", // .. "http_only_cookie_attribute": false }, "success": true, "errors": [], "messages": [] } ```
|
changelog detected ✅ |
|
This functionality has been released in v3.32.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of cloudflare/cloudflare-go#1164 we have the ability to use the inbuilt logger for redacting sensitive HTTP headers.
Previously, we were discarding the provided logger due to instantiating a new
cleanhttpclient to use however, with this change we are now using the cloudflare-go logger for HTTP interactions inside the Terraform Core sink.By default we redact the values found in the following HTTP headers (not the headers themselves) in the entire HTTP interaction:
X-Auth-EmailX-Auth-KeyX-Auth-User-Service-KeyAuthorizationAnd here is an example of the logger in action for
TF_LOG=DEBUG.