Fix Issues with BandwidthMeasurementEngine stop method and Performance API #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BandwidthMeasurementEngine
class. Stop method of this class is calledonConnectionError
, as shown in the following links::https://github.com/cloudflare/speedtest/blob/main/src/engines/BandwidthEngine/ParallelLatency.js#L44
https://github.com/cloudflare/speedtest/blob/main/src/engines/BandwidthEngine/ParallelLatency.js#L78
I added stop method which calls
this.pause()
, which may need to be updated accordingly. See:https://github.com/bekmuradov/speedtest/blob/main/src/engines/BandwidthEngine/BandwidthEngine.js#L126-L128
performance.getEntriesByName()
method is returning an empty array, which means there are no timing entries with the specified url. As a result, when attempting to access .slice(-1)[0], it shows warning message and there is no timing data. To fix these issues, we need to ensure that the Performance API is correctly capturing the timing entries for each request.