Improve e2es (retries, wasm, server-actions, etc...) #636
Conversation
|
|
🧪 Prereleases are available for testing 🧪 @cloudflare/next-on-pagesYou can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/7544522774/npm-package-next-on-pages-636@cloudflare/eslint-plugin-next-on-pagesYou can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/7544522774/npm-package-eslint-plugin-next-on-pages-636 |
dario-piotrowicz
force-pushed
the
improve-e2es
branch
2 times, most recently
from
aa01afe to
882d49b
Compare
| @@ -478,7 +478,6 @@ describe('processOutputDir', () => { | |||
| const outputDir = vercelDir; | |||
|
|
|||
| expect(readdirSync(outputDir)).toEqual(['index.js', 'nested']); | |||
| expect(existsSync(outputDir)).toEqual(true); | |||
There was a problem hiding this comment.
I've removed this because it was constantly failing in the CI for some reason 😕
I could not understand why and I could not reproduce this locally 😕
(I suspect this to be a weird github actions/nodejs bug 😕🤷)
I thought of removing this as it is also an unnecessary check, since as you can see from the line above, we already check the content of the directory, so checking for its existence afterwords is really unnecessary, so hopefully this is fine
dario-piotrowicz
changed the title
notes: - this is needed so that we can add e2e tests for server actions: cloudflare/workers-sdk#4630 - we the commit also updates node from 18 to 20 in e2e github acitons testing, this is necessary for using the latest wrangler release, see: cloudflare/workers-sdk#4563 (comment)
dario-piotrowicz
force-pushed
the
improve-e2es
branch
from
882d49b to
e965501
Compare
This PR improves the e2e by adding (hopefully) making them more reliable and adds tests for the wasm integration and server actions, plus other small improvements
For more details check the commit messages as those should hopefully be pretty self explanatory 🙂