-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce cloudflare
platform object containing all the cloudflare context relative to the request
#233
introduce cloudflare
platform object containing all the cloudflare context relative to the request
#233
Conversation
…context relative to the request
🦋 Changeset detectedLatest commit: e0cc582 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should move env
away from process.env
. This means apps won't "just work" when deployed to Pages.
I'm not sold on cf
or ctx
either, but don't really have any meaningfully different ideas for those.
ah.... I guess for I'm not sure what you don't like about |
After discussing it offline with @GregBrimble we decided to try something different, so I am closing this PR |
Yeah, why hide This our fork version askcodebase@5e6c412 and we released our self-maintained package @dario-piotrowicz can you propose this topic again and discuss with your colleagues ? The community do need this feature. Thx! |
@shiqimei thank you for your comment 🙂 I will bring this to the team and see if we can decide, it does sound like it would be a valuable change (especially for now and we can change things later in a major version if need be) One small thing to note is that your solution does introduce a sort of breaking change because if users has a binding called Regarding why we haven't yet implemented a solution, that's only because we've been trying to decide on an agnostic solution that could be applied generally by anyone using Cloudflare workers/pages, we have some ideas but it's taking quite some time since different teams are involved, truthfully I need to chase that up! |
No description provided.