Merge pull request #1190 from ryotarai/fix-duration-of-video-type

cloudflare · Jun 6, 2023 · 8719971 · 8719971
2 parents 4ad0491 + 5584c5b
commit 8719971
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/.changelog/1190.txt b/.changelog/1190.txt
@@ -0,0 +1,7 @@
+```release-note:bug
+stream: Fix a bug that cannot unmarshal video duration number.
+```
+
+```release-note:breaking-change
+stream: StreamVideo.Duration has changed from int to float64.
+```
diff --git a/stream.go b/stream.go
@@ -28,7 +28,7 @@ var (
 type StreamVideo struct {
 	AllowedOrigins        []string                 `json:"allowedOrigins,omitempty"`
 	Created               *time.Time               `json:"created,omitempty"`
-	Duration              int                      `json:"duration,omitempty"`
+	Duration              float64                  `json:"duration,omitempty"`
 	Input                 StreamVideoInput         `json:"input,omitempty"`
 	MaxDurationSeconds    int                      `json:"maxDurationSeconds,omitempty"`
 	Meta                  map[string]interface{}   `json:"meta,omitempty"`

diff --git a/stream_test.go b/stream_test.go
@@ -22,7 +22,7 @@ const (
       "example.com"
     ],
     "created": "2014-01-02T02:20:00Z",
-    "duration": 300,
+    "duration": 300.5,
     "input": {
       "height": 1080,
       "width": 1920
@@ -86,7 +86,7 @@ func createTestVideo() StreamVideo {
 	return StreamVideo{
 		AllowedOrigins:     []string{"example.com"},
 		Created:            &created,
-		Duration:           300,
+		Duration:           300.5,
 		Input:              StreamVideoInput{Height: 1080, Width: 1920},
 		MaxDurationSeconds: 300,
 		Modified:           &modified,
@@ -285,7 +285,7 @@ func TestStream_ListVideos(t *testing.T) {
       "example.com"
     ],
     "created": "2014-01-02T02:20:00Z",
-    "duration": 300,
+    "duration": 300.5,
     "input": {
       "height": 1080,
       "width": 1920