Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Static Assets] Rename experimental_serve_directly to run_worker_first #19411

Merged

Conversation

WillTaylorDev
Copy link
Contributor

@WillTaylorDev WillTaylorDev commented Jan 24, 2025

Updates the naming for the Worker-first configuration.

Summary

Provides rename for experimental_serve_directly.

Documentation checklist

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/rename-serve-directly-static-assets branch from aa6bedf to 8398c97 Compare January 24, 2025 15:26
@github-actions github-actions bot added size/s product:workers Related to Workers product labels Jan 24, 2025
Copy link

cloudflare-workers-and-pages bot commented Jan 24, 2025

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4bfb844
Status: ✅  Deploy successful!
Preview URL: https://eec03ec2.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://willtaylor-rename-serve-dire.cloudflare-docs-7ou.pages.dev

View logs

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/rename-serve-directly-static-assets branch from 8398c97 to 18ab7da Compare January 24, 2025 16:56
@WillTaylorDev WillTaylorDev marked this pull request as ready for review January 27, 2025 15:54
Copy link
Contributor

@irvinebroque irvinebroque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to be above a certain version of Wrangler in order for this to work?

@WillTaylorDev
Copy link
Contributor Author

Do you need to be above a certain version of Wrangler in order for this to work?

We will! Is it common for us to document the version of Wrangler features are available (FWIW it's not yet merged into main, so I don't quite have a timeline on release)

Updates the naming for the Worker-first configuration.
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/rename-serve-directly-static-assets branch from 18ab7da to 4bfb844 Compare January 29, 2025 21:38
@WillTaylorDev WillTaylorDev merged commit 4239ae2 into production Jan 30, 2025
12 checks passed
@WillTaylorDev WillTaylorDev deleted the willtaylor/rename-serve-directly-static-assets branch January 30, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:workers Related to Workers product size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants