Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature nodejs compat issues in troubleshooting #19288

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

thomasgauvin
Copy link
Contributor

Recent changes to create-cloudflare have removed default nodejs_compat from templates. While we discuss why this was removed and if we can make it the default once again, adding an entry in our troubleshooting to notify anyone landing on Hyperdrive troubleshooting that they may be encountering node compat issues.

@thomasgauvin thomasgauvin requested review from elithrar, sejoker, Oxyjun and a team as code owners January 17, 2025 22:07
@github-actions github-actions bot added the product:hyperdrive Hyperdrive: https://developers.cloudflare.com/hyperdrive/ label Jan 17, 2025
@thomasgauvin
Copy link
Contributor Author

See cloudflare/workers-sdk#7388

Copy link

cloudflare-workers-and-pages bot commented Jan 17, 2025

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: c1ed7ba
Status: ✅  Deploy successful!
Preview URL: https://cb948593.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://thomasgauvin-patch-4.cloudflare-docs-7ou.pages.dev

View logs

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 files reviewed, 1 total issue(s) found.

@sejoker sejoker merged commit e52cc45 into production Jan 23, 2025
11 of 12 checks passed
@sejoker sejoker deleted the thomasgauvin-patch-4 branch January 23, 2025 21:53
deadlypants1973 pushed a commit that referenced this pull request Jan 29, 2025
* Feature nodejs compat issues in troubleshooting

* thomasgauvin: fix formatting on hyperdrive nodejs errors troubleshooting page

* thomasgauvin: nit
kodster28 pushed a commit that referenced this pull request Jan 30, 2025
* Feature nodejs compat issues in troubleshooting

* thomasgauvin: fix formatting on hyperdrive nodejs errors troubleshooting page

* thomasgauvin: nit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:hyperdrive Hyperdrive: https://developers.cloudflare.com/hyperdrive/ size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants