Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instruct to install Node.js w/Node Version Manager #191

Closed
wants to merge 1 commit into from

Conversation

JasonCoombs
Copy link

No description provided.

@adamschwartz
Copy link
Contributor

@rita3ko @ispivey

Copy link
Contributor

@ispivey ispivey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change to make the language fit the surrounding style, but otherwise LGTM (I'll also propose this on the wrangler PR) . Thanks for the contribution!

@@ -16,7 +16,7 @@ Cloudflare Workers provides a serverless execution environment that allows you t

## Installing the Workers CLI

To install [`wrangler`](https://github.com/cloudflare/wrangler), the Workers CLI, ensure you have [`npm` installed](https://www.npmjs.com/get-npm), then run:
To install [`wrangler`](https://github.com/cloudflare/wrangler), the Workers CLI, ensure you have [`npm` installed](https://www.npmjs.com/get-npm) (NOTE: in typical installations you MUST USE a Node.js Version Manager e.g. use `nvm install node` to install Node.js and npm) then run:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To install [`wrangler`](https://github.com/cloudflare/wrangler), the Workers CLI, ensure you have [`npm` installed](https://www.npmjs.com/get-npm) (NOTE: in typical installations you MUST USE a Node.js Version Manager e.g. use `nvm install node` to install Node.js and npm) then run:
To install [`wrangler`](https://github.com/cloudflare/wrangler), the Workers CLI, ensure you have [`npm` installed](https://www.npmjs.com/get-npm). Typically, you _must_ also use a Node version manager like [`nvm`](https://github.com/nvm-sh/nvm#installing-and-updating). Then, run:

@rita3ko
Copy link
Contributor

rita3ko commented Oct 2, 2020

hi @JasonCoombs — we've migrated our content to a new repo, so i've reopened your PR here: cloudflare/cloudflare-docs#38

closing this. thank you for submitting the change!

@rita3ko rita3ko closed this Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants