Update with latest RSA from go stdlib #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukevalenta
reviewed
May 4, 2022
| func decrypt(random io.Reader, priv *rsa.PrivateKey, c *big.Int) (m *big.Int, err error) { | ||
| // TODO(agl): can we get away with reusing blinds? | ||
| if c.Cmp(priv.N) > 0 { | ||
| err = rsa.ErrDecryption | ||
| return | ||
| } | ||
| if priv.N.Sign() == 0 { | ||
| return nil, rsa.ErrDecryption | ||
| } | ||
|
|
||
| var ir *big.Int | ||
| if random != nil { |
There was a problem hiding this comment.
Are we missing this line? https://cs.opensource.google/go/go/+/master:src/crypto/rsa/rsa.go;l=558
There was a problem hiding this comment.
it shuffles the random source in case a user-provided source is provided.
in this package, the random source is always crypto/rand, which it's assumed to be secure.
lukevalenta
approved these changes
May 4, 2022
bwesterb
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates with latest RSA from go stdlib.
Also removes some code not used by blindRSA.