all: formatting code with golangci-lint #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armfazh
force-pushed
the
formatCode
branch
2 times, most recently
from
8f6adda
to
73cfba2
Compare
bwesterb
approved these changes
Mar 4, 2022
Lekensteyn
approved these changes
Mar 4, 2022
There was a problem hiding this comment.
Some open questions about the crypto/sha256 and crypto/sha512 imports where an import comment was dropped. Changes look reasonable in any case, but you might want to update the commit message with the kind of changes (moved json file to testdata directory, formatting changes using <whatever command you used>) such that it can be reproduced.
Code formatted after resolving issues reported by $ make lint some of them were automatically fixed by running. $ make lint-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enables two linters that automatically format code using
Changes: