Fix regression with json marshaller/unmarshaller #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
n3wscott
reviewed
Apr 12, 2021
| @@ -359,7 +359,8 @@ func consumeDataAsBytes(e *Event, isBase64 bool, b []byte) error { | |||
| } | |||
|
|
|||
| mt, _ := e.Context.GetDataMediaType() | |||
| if mt != ApplicationJSON && mt != TextJSON { | |||
| // Empty content type assumes json | |||
| if mt != "" && mt != ApplicationJSON && mt != TextJSON { | |||
There was a problem hiding this comment.
This will throw new errors when the body is just an unquoted string or random bytes.
There was a problem hiding this comment.
Why? Can you provide a test case where do you think this is going to fail? In any case, the spec claims that this assumption is safe (at least, that's my understanding): https://github.com/cloudevents/spec/blob/v1.0.1/json-format.md#31-handling-of-data
There was a problem hiding this comment.
ah ok this is already in the context of structured mode decoding.
LGTM
n3wscott
approved these changes
Apr 12, 2021
|
@n3wscott @slinkydeveloper will this fix result in a 2.4.1 release ? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the unmarshalling when there is some json in the event data, but there is no content type.
Signed-off-by: Francesco Guardiani francescoguard@gmail.com