Prevent string resource lookup if not required #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Campbell Harding-Deason <campbell.harding-deason@firstaml.com>
jskeet
reviewed
Sep 1, 2023
| /// <param name="condition">The condition to validate; this method will throw an <see cref="ArgumentException"/> if this is false.</param> | ||
| /// <param name="paramName">The name of the parameter being validated. May be null.</param> | ||
| /// <param name="messageFunc">A func that returns the message to use in the exception, if one is thrown.</param> | ||
| public static void CheckArgument([DoesNotReturnIf(false)] bool condition, string paramName, Func<string> messageFunc) |
There was a problem hiding this comment.
Could we keep this internal to start with? It looks like we only need it to be internal for now - we're not using resource strings elsewhere, and I suspect other users won't be doing so either, so I'd prefer to avoid exposing it.
There was a problem hiding this comment.
Sure thing 👍
Signed-off-by: Campbell Harding-Deason <campbell.harding-deason@firstaml.com>
jskeet
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #264