Skip to content

Conversation

timveil
Copy link
Contributor

@timveil timveil commented Jan 9, 2024

this pr fixes #653 which adds support for the custom_ticket_statuses api call found here...https://developer.zendesk.com/api-reference/ticketing/tickets/custom_ticket_statuses/

Copy link
Collaborator

@PierreBtz PierreBtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Same remarks as the previous PR:

  • spotless need to be run using java 8
  • would you mind adding a test?

Thanks!

@PierreBtz
Copy link
Collaborator

Sorry, missed the draft status...

@timveil timveil marked this pull request as ready for review January 19, 2024 21:16
@timveil timveil requested a review from duemir as a code owner January 19, 2024 21:16
@timveil
Copy link
Contributor Author

timveil commented Jan 23, 2024

I think this is ready if you are

Copy link
Collaborator

@PierreBtz PierreBtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, it seems our test instance doesn't have custom status instance enabled so I cannot have a test running on this feature.

@PierreBtz PierreBtz merged commit 38715db into cloudbees-oss:master Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for custom_ticket_statuses
2 participants