Do not generate nftables chains for network policies if FilterTableName is empty #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibot3
force-pushed
the
ibot3/optional-filter
branch
from
83b0f40 to
16b4951
Compare
ibot3
changed the title
ibot3
force-pushed
the
ibot3/optional-filter
branch
from
16b4951 to
b15a5db
Compare
ibot3
changed the title
… empty As the filter feature isn't always required and VyOS 1.4 does not have fitting nftables chains by default, it is useful that this feature can be disabled by letting FilterTableName empty.
ibot3
force-pushed
the
ibot3/optional-filter
branch
from
b15a5db to
3be1387
Compare
horazont
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the filter feature isn't always required and VyOS 1.4 does not have fitting nftables chains by default, it is useful that this feature can be disabled by letting FilterTableName empty.
Manually tested on VyOS.