Fix incompatibility with OVN-based clouds #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horazont
reviewed
Jun 6, 2024
horazont
reviewed
Jun 20, 2024
There was a problem hiding this comment.
Reviewed by me and tested by @Lykos153 .
@tschuettig Could you please squash the commits into commits which make sense individually and provide them with commit messages according to https://cbea.ms/git-commit/ ?
These values are used by the OpenStackL3PortManager to create a VRRP setup that is compatible with new versions of the OVN ML2 plugin and need to be added to the configuration with yaook/k8s. Additionally, the openstack config was moved to the config package to avoid cyclic imports.
To setup VRRP with new versions of the OVN ML2 plugin, additional IP addresses of the agent configuration (at the moment of this commit only the IP address of the VIP port is used) and all fixed IP addresses of all L3 ports need to be added to the allowed address pairs of each agent node. This is done by overwriting the address pairs accordingly after the provisioning or deletion of a L3 port as well as periodically during the entire runtime of the k8s-lbaas using the EnsureAgentsStateJob. The periodic job is used to ensure the setup will still be created after an agent was unreachable. As a part of this commit functions provided by the package openstack/networking/v2/ports were wrapped into the PortClient to allow better testability.
tschuettig
force-pushed
the
fix-ovn-based-clouds
branch
from
ff10e45 to
17b761e
Compare
|
@horazont Hope this is better now, if something could be improved let me know. |
horazont
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
The changes can be tested using the branch
tschuettig/issue-659-lbaasfrom the yaook/k8s repository. (MR intosstrk/issue-659is pending)Fixes #53