Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope IP and Port listings to current project #51

Merged

Conversation

kgube
Copy link
Contributor

@kgube kgube commented Oct 20, 2023

The Neutron API will list resources from all Projects that the user has access too, not just the current project.
This patch adds the current project as a filter to the Port and Floating IP listings to avoid interference with other projects.

Fixes #49

@kgube kgube force-pushed the feature/project-scoped-openstack-listings branch from 502cc84 to edfaefb Compare November 1, 2023 15:08
@kgube kgube force-pushed the feature/project-scoped-openstack-listings branch from edfaefb to d4b4a4f Compare November 2, 2023 12:47
@horazont
Copy link
Collaborator

horazont commented Nov 2, 2023

We discussed in yaook/k8s and decided that it's ok to require project-id now. Just ensure that the LBaaS controller crashes if the project-id is unset and we're good.

@kgube kgube force-pushed the feature/project-scoped-openstack-listings branch from d4b4a4f to 094e037 Compare November 2, 2023 15:42
@horazont
Copy link
Collaborator

horazont commented Nov 3, 2023

Tested this in my toy cluster and LBaaS still works, which is good. Merging this and preparing 0.7.0.

@horazont horazont merged commit 2bcbe2c into cloudandheat:master Nov 3, 2023
3 checks passed
@horazont
Copy link
Collaborator

horazont commented Nov 3, 2023

Thanks a lot, MR for bumping the version in yaook/k8s is here: https://gitlab.com/yaook/k8s/-/merge_requests/938

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure that IP and Port listings are scoped to the current project
2 participants