Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/get ports #29

Merged
merged 2 commits into from
Jun 8, 2022
Merged

Fix/get ports #29

merged 2 commits into from
Jun 8, 2022

Conversation

expektorans
Copy link

@expektorans expektorans commented Jun 8, 2022

GetPorts: fix referencing of ports

This commit fixes the collection of ports by storing the actual item
instead of the address of the loop variable in the list. An example,
because I find pointers confusing:

Let's say our actual ports are [1, 2, 3]. Previously, GetPorts returned
[3, 3, 3], and now we receive (as expected) [1, 2, 3].

I stumbled over this problem while applying force to lbaas by having a
script create and delete services at random intervals as well as
manually deleting the lbaas and the workload pod. This should resolve
the resource leaks observed in #28. If we're lucky this might also help
with lbaas eating FIPs.

Yannic Ahrens added 2 commits June 8, 2022 17:14
This commit fixes the collection of ports by storing the actual item
instead of the address of the loop variable in the list. An example,
because I find pointers confusing:

Let's say our actual ports are [1, 2, 3]. Previously, GetPorts returned
[3, 3, 3], and now we receive (as expected) [1, 2, 3].

I stumbled over this problem while applying force to lbaas by having a
script create and delete services at random intervals as well as
manually deleting the lbaas and the workload pod. This should resolve
the resource leaks observed in cloudandheat#28. If we're lucky this might also help
with lbaas eating FIPs.
This commit adds a minor introduction how to test and run the lbaas
controller locally on your workstation.
@horazont horazont merged commit ca42626 into cloudandheat:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants