Fix/dont lose ips #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horazont
reviewed
Feb 12, 2021
internal/openstack/port_manager.go
Outdated
| @@ -185,8 +188,9 @@ func (pm *OpenStackL3PortManager) ProvisionPort() (string, error) { | |||
| if pm.cfg.UseFloatingIPs { | |||
| err = pm.provisionFloatingIP(port.ID) | |||
| if err != nil { | |||
| klog.Warningf("Couldn't provide floating ip for port=%v", port.ID) | |||
added 2 commits
February 12, 2021 10:26
If for some reason the creation of a floating IP (fip) in OpenStack fails it should be made clear this is unexpected behaviour. One obvious reason for a failed fip creation are quotas. If no fip was provided, this led to the following execution flow: - fip creation failed - port is deleted - "" is returned as port ID - in the next round, the controller wants to look up the port with non-existing port with the zero-length ID and crashes - horrible things happen from this stage on By returning an error none of the above will happen and the pending service(s) are re-queued for port/fip creation in the next iteration.
This commit injects debug statements in several spots to trace the internal process of mapping and unmapping services to L3 ports.
expektorans
force-pushed
the
fix/dont-lose-ips
branch
from
0cbc00f to
15bfa1f
Compare
horazont
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional debug statements and treat failed fip creation as an error. See #23