Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use -Zbuild-std #69

Merged
merged 3 commits into from
Oct 2, 2020
Merged

Use -Zbuild-std #69

merged 3 commits into from
Oct 2, 2020

Conversation

josephlr
Copy link
Contributor

@josephlr josephlr commented Oct 2, 2020

Fixes #67

For details about the changes, see each step.

Note that the only major difference from cargo-xbuild is that:

  • This doesn't require and external tool
  • When not using --release, libcore and compiler-builtins are built in debug mode
    • This means we cannot enable LTO with debug mode anymore (but that's OK).

@josephlr
target.json: Update data-layout
7aa85ad 
This makes us match LLVM's default for x86_64, and prevents a warning.

Signed-off-by: Joe Richey <joerichey@google.com>
@josephlr
build: Disable LTO in debug mode
e019f49 
If we want the debug build to be fast, there's no reason to have LTO.

Also, using LTO in debug mode breaks -Zbuild-std

Signed-off-by: Joe Richey <joerichey@google.com>
@josephlr
CI: Remove all references to cargo-xbuild
aded463 
Also, make sure that the debug build also works.

Signed-off-by: Joe Richey <joerichey@google.com>
rbradford
rbradford approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@rbradford rbradford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Great work!

@rbradford rbradford merged commit 12a3c21 into cloud-hypervisor:master Oct 2, 2020
@josephlr josephlr deleted the build-std branch October 3, 2020 08:24
@josephlr josephlr mentioned this pull request Oct 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbradford rbradford rbradford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to -Zbuild-std
2 participants
@josephlr @rbradford