Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build on intel machines. #143

Closed
rishirsinha opened this issue Jul 30, 2021 · 3 comments
Closed

Unable to build on intel machines. #143

rishirsinha opened this issue Jul 30, 2021 · 3 comments

Comments

@rishirsinha
Copy link

After getting the latest nightly build I am still unable to build on linux machines.

I am getting the following:

note: instantiated into assembly here
--> :53:10
|
53 | movw %ax, %ss
| ^

error: unknown token in expression

on every line of the assembly file. Is there something else I need to setup except for what I can see in the build scripts or the main page.

retrage added a commit to retrage/rust-hypervisor-firmware that referenced this issue Jul 30, 2021
As reported in issue cloud-hypervisor#143, recent nightly rustc fails to compile the
assembly file because it uses AT&T syntax. It is also suggested that use
raw option when using `include_str!` macro.

https://rust-lang.github.io/rfcs/2873-inline-asm.html#options-1
rust-lang/rust#86599

Signed-off-by: Akira Moroo <retrage01@gmail.com>
@retrage
Copy link
Contributor

retrage commented Jul 30, 2021

I made a quick fix.

retrage added a commit that referenced this issue Jul 30, 2021
As reported in issue #143, recent nightly rustc fails to compile the
assembly file because it uses AT&T syntax. It is also suggested that use
raw option when using `include_str!` macro.

https://rust-lang.github.io/rfcs/2873-inline-asm.html#options-1
rust-lang/rust#86599

Signed-off-by: Akira Moroo <retrage01@gmail.com>
@retrage
Copy link
Contributor

retrage commented Aug 2, 2021

@rishirsinha This is because default inline behavior has been changed in recent Rust nightly build. I committed the fix in PR #144. If you confirmed that it is fixed in the latest master branch, please close this issue.

@rishirsinha
Copy link
Author

This did fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants