remove temporarily tokio-uring #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wllenyj
requested review from
bergwolf,
imeoer,
jiangliu,
liubogithub and
eryugey
as code owners
wllenyj
force-pushed
the
uring
branch
11 times, most recently
from
d6087c0
to
958fd80
Compare
The pendding PRs has been merged, We should use `crate.io` directly instead of this temporary copy. tokio-rs/tokio-uring#87 tokio-rs/tokio-uring#88 Signed-off-by: wanglei01 <wllenyj@linux.alibaba.com>
Upgraded virtio-queue to 0.6 Upgraded vhost to 0.5 Signed-off-by: wanglei01 <wllenyj@linux.alibaba.com>
Useful for debugging unit test failures. Signed-off-by: wanglei01 <wllenyj@linux.alibaba.com>
The ci of docker-smoke get errors. ``` error: package `scoped-tls v1.0.1` cannot be built because it requires rustc 1.59 or newer, while the currently active rustc version is 1.58.1 ``` Signed-off-by: wanglei01 <wllenyj@linux.alibaba.com>
If put Runtime into thread_local, the order of Drop calls is platform-dependent. This will case panic in the `tokio-uring` Runtime Drop function. The pr tokio-rs/tokio-uring#173 will fix. We will revert this, if it is meraged. Signed-off-by: wanglei01 <wllenyj@linux.alibaba.com>
Signed-off-by: wanglei01 <wllenyj@linux.alibaba.com>
Currently, the io-uring crate has implemented functions such as readv/readv_at etc, so there is no need to use RawFd to implement. Signed-off-by: wanglei01 <wllenyj@linux.alibaba.com>
```
error: deref which would be done by auto-deref
--> src/transport/mod.rs:295:36
|
295 | let bytes_consumed = f(&*bufs)?;
| ^^^^^^ help: try this: `&bufs`
|
= note: `-D clippy::explicit-auto-deref` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
```
Signed-off-by: wanglei01 <wllenyj@linux.alibaba.com>
jiangliu
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pendding PRs has been merged, We should use
crate.iodirectly instead of this temporary copy.tokio-rs/tokio-uring#87
tokio-rs/tokio-uring#88
Signed-off-by: wanglei01 wllenyj@linux.alibaba.com