Introduce the common module. #84
Conversation
wllenyj
requested review from
bergwolf,
imeoer,
jiangliu,
liubogithub and
eryugey
as code owners
wllenyj
force-pushed
the
common
branch
3 times, most recently
from
82b0a1f
to
c40727e
Compare
Signed-off-by: wllenyj <wllenyj@linux.alibaba.com>
| @@ -93,3 +93,6 @@ impl FuseServer { | |||
| This project is licensed under | |||
| - [Apache License](http://www.apache.org/licenses/LICENSE-2.0), Version 2.0 | |||
| - [BSD-3-Clause License](https://opensource.org/licenses/BSD-3-Clause) | |||
|
|
|||
| Source code under [src/tokio-uring] is temporarily copied from [tokio-uring](https://github.com/tokio-rs/tokio-uring) | |||
| with modifications, which is licensed under [MIT](https://github.com/tokio-rs/tokio-uring/blob/master/LICENSE). | |||
There was a problem hiding this comment.
Could you list corresponding upstream tokio-uring PRs? So that we can drop the code once the changes are merged.
Also, another way (other than copying the code here) is to fork tokio-uring somewhere and make fuse-backend-rs depend on the fork temporarily. The advantage is that it would be clear what is changed from tokio-uring and it's possible to rebase/merge tokio-uring upstream changes while the proposed changes are still under review.
There was a problem hiding this comment.
If we temporarily fork the tokio-uring crate, we must publish that forked tokio-uring crate before we could publish the fuse-backend-rs.
There was a problem hiding this comment.
crates.io does not allow packages to be published with git dependencies and path dependencies.
There was a problem hiding this comment.
ok, I see. Let's live with it in fuse-backend-rs then. But still, please list out the ongoing tokio-uring PRs so that we know when to drop the in-tree tokio-uring later on. Thanks!
There was a problem hiding this comment.
added
Please reveiw again.
Tempoarily include tokio-uring into dbs-fuse, so we could publish dbs-fuse. We will switch to upstream crate once our enhancements have been merged and new version is available. Signed-off-by: wllenyj <wllenyj@linux.alibaba.com> Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
Async File wrapper for tokio::File and tokio_uring::File. Async runtime supports tokio and tokio-uring. Signed-off-by: wllenyj <wllenyj@linux.alibaba.com> Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
Use file_traits directly. Signed-off-by: wllenyj <wllenyj@linux.alibaba.com>
```
error: this lifetime isn't used in the impl
--> src/passthrough/mod.rs:139:6
|
139| impl<'a> InodeData {
| ^^
|
= note: `-D clippy::extra-unused-lifetimes` implied by `-D warnings`
= help: for further information visit
https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
```
Signed-off-by: wllenyj <wllenyj@linux.alibaba.com>
|
The tokio-uring is based on tokio-rs/tokio-uring@6cacd95 with three more PRs applied: |
|
tokio-rs/tokio-uring#89 got merged now:) |
Major changes include.
transportmodule tocommonmodule.commonmodule.pub use file_traitin transport module.The tokio-uring is based on tokio-rs/tokio-uring@6cacd95
with three more PRs applied:
tokio-rs/tokio-uring#87
tokio-rs/tokio-uring#88
tokio-rs/tokio-uring#89 got merged now:)