Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow service names with dots #1208

Closed
devdattakulkarni opened this issue Feb 6, 2024 · 0 comments
Closed

Disallow service names with dots #1208

devdattakulkarni opened this issue Feb 6, 2024 · 0 comments

Comments

@devdattakulkarni
Copy link
Contributor

If we define a Service name with numbers in it, then the CRD registration fails with following error:

"status": "Error:The CustomResourceDefinition \"atomic1.0.16s.platformapi.kubeplus\" is invalid: \n* spec.names.plural: Invalid value: \"atomic1.0.16s\": a DNS-1035 label must consist of lower case alphanumeric characters or '-', start with an alphabetic character, and end with an alphanumeric character (e.g. 'my-name', or 'abc-123', regex used for validation is '[a-z]([-a-z0-9]*[a-z0-9])?')\n* spec.names.singular: Invalid value: \"atomic1.0.16\": a DNS-1035 label must consist of lower case alphanumeric characters or '-', start with an alphabetic character, and end with an alphanumeric character (e.g. 'my-name', or 'abc-123', regex used for validation is '[a-z]([-a-z0-9]*[a-z0-9])?')\n* spec.names.kind: Invalid value: \"Atomic1.0.16\": may have mixed case, but should otherwise match: a DNS-1035 label must consist of lower case alphanumeric characters or '-', start with an alphabetic character, and end with an alphanumeric character (e.g. 'my-name', or 'abc-123', regex used for validation is '[a-z]([-a-z0-9]*[a-z0-9])?')\n* spec.names.listKind: Invalid value: \"Atomic1.0.16List\": may have mixed case, but should otherwise match: a DNS-1035 label must consist of lower case alphanumeric characters or '-', start with an alphabetic character, and end with an alphanumeric character (e.g. 'my-name', or 'abc-123', regex used for validation is '[a-z]([-a-z0-9]*[a-z0-9])?')\n

We should disallow service names consisting of dots in them.

devdattakulkarni added a commit that referenced this issue Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant