Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pqueue #25

Merged
merged 3 commits into from
Aug 13, 2019
Merged

Pqueue #25

merged 3 commits into from
Aug 13, 2019

Conversation

clormor
Copy link
Owner

@clormor clormor commented Aug 13, 2019

No description provided.

import java.util.List;
import java.util.PriorityQueue;

import static io.github.clormor.hackerrank.datastructures.priorityqueue.Student.COMPARE_STUDENTS;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong lexicographical order for 'io.github.clormor.hackerrank.datastructures.priorityqueue.Student.COMPARE_STUDENTS' import. Should be before 'java.util.PriorityQueue'.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bugger off


import org.immutables.value.Value;

import java.util.Comparator;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong lexicographical order for 'java.util.Comparator' import. Should be before 'org.immutables.value.Value'.

@codeclimate
Copy link

codeclimate bot commented Aug 13, 2019

Code Climate has analyzed commit 5311e62 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 2

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@clormor clormor merged commit 95bf2fe into develop Aug 13, 2019
@clormor clormor deleted the pqueue branch August 13, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant