suppress expected spotbugs issue

clormor · Aug 13, 2019 · cf420bc · cf420bc
1 parent 2744964
commit cf420bc
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/build.gradle b/build.gradle
@@ -12,7 +12,6 @@ plugins {
     id 'java'
     id 'jacoco'
     id "com.github.spotbugs" version "2.0.0"
-    //id 'findbugs'
     id 'eclipse'
     id 'idea'
     id 'maven'
@@ -41,6 +40,7 @@ repositories {
 
 dependencies {
     compile "com.google.guava:guava:$guavaVersion"
+    compile "com.github.spotbugs:spotbugs-annotations:$spotbugsVersion"
     testCompile "junit:junit:$junitVersion"
 }
 

diff --git a/gradle.properties b/gradle.properties
@@ -4,4 +4,5 @@ version = 0.1.2-SNAPSHOT
 guavaVersion = 27.0.1-jre
 immutablesVersion = 2.7.5
 junitVersion = 4.12
+spotbugsVersion = 3.1.12
 
diff --git a/src/main/java/io/github/clormor/hackerrank/advanced/ReflectionExample.java b/src/main/java/io/github/clormor/hackerrank/advanced/ReflectionExample.java
@@ -1,5 +1,7 @@
 package io.github.clormor.hackerrank.advanced;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+
 import java.lang.reflect.Method;
 import java.util.Arrays;
 
@@ -27,15 +29,17 @@ static class Inner {
 
         class Private {
 
+            @SuppressFBWarnings
             private boolean powerOf2(int n) {
-                if (n == 1) {
+                if (n == 1 || n == 2) {
                     return true;
                 }
-                do {
+                while (n > 1) {
+                    n /= 2;
                     if (n == 2) {
                         return true;
                     }
-                } while ((n /= 2) > 1);
+                }
                 return false;
             }
         }