Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: replace pomegranate with alembic #224

Closed
wants to merge 2 commits into from

Conversation

benalbrecht
Copy link

fixes #206

this allows hotloading in java10, but it probably requires some more testing.

@benedekfazekas
Copy link
Member

wohoo! this supposed to be backward compatible too, right?

@benedekfazekas
Copy link
Member

seems to be a genuine failure i am getting the same error as on travis locally when running test wo/ mranderson. I guess we need to figure out the right version of piggieback?!

:dependencies [[org.clojure/clojurescript "1.9.89"]
[com.cemerick/piggieback "0.2.2"]
:dependencies [[org.clojure/clojurescript "1.10.238"]
[cider/piggieback "0.2.3"]
Copy link
Member

@bbatsov bbatsov Jun 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be 0.3.6.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and cemerick.piggieback needs to be updated in refactor-nrepl.ns.resolve-missing-test

there are still failures and errors when tests are run but it compiles after the above changes

@expez
Copy link
Member

expez commented Jun 8, 2018

Very exciting stuff, @benalbrecht!

@bbatsov
Copy link
Member

bbatsov commented Jul 3, 2018

wip: replace pomegranate with alembic #224

I think that's the other way. ;-) Btw, what's the deal with pomegranate these days? Is it maintained?

@bbatsov
Copy link
Member

bbatsov commented Jul 18, 2018

Btw, a recent patch in nrepl/nrepl#35 might render all of this obsolete - we can probably just use tools.deps directly. And we can probably even move this to CIDER itself and maybe one day to nREPL itself.

@expez
Copy link
Member

expez commented Jul 18, 2018

@bbatsov That sounds like a good way forward! Good input! 👍

@bbatsov
Copy link
Member

bbatsov commented Jul 18, 2018

@expez In light of this development I'd suggest for you to just remove the hotloading support, which will also solve the problem with getting out a new snapshot and we'll revisit this a couple of months from now when clojure-emacs/cider-nrepl#540 is live and we're running happily on the modern nREPL.

@expez
Copy link
Member

expez commented Jul 18, 2018

@bbatsov Yeah, that makes sense to me too.

@bbatsov
Copy link
Member

bbatsov commented Mar 20, 2019

I think we can close this one. No need to keep open stale PRs forever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't work with Java 9
4 participants