-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: replace pomegranate with alembic #224
Conversation
wohoo! this supposed to be backward compatible too, right? |
seems to be a genuine failure i am getting the same error as on travis locally when running |
:dependencies [[org.clojure/clojurescript "1.9.89"] | ||
[com.cemerick/piggieback "0.2.2"] | ||
:dependencies [[org.clojure/clojurescript "1.10.238"] | ||
[cider/piggieback "0.2.3"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should be 0.3.6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and cemerick.piggieback
needs to be updated in refactor-nrepl.ns.resolve-missing-test
there are still failures and errors when tests are run but it compiles after the above changes
Very exciting stuff, @benalbrecht! |
I think that's the other way. ;-) Btw, what's the deal with pomegranate these days? Is it maintained? |
Btw, a recent patch in nrepl/nrepl#35 might render all of this obsolete - we can probably just use |
@bbatsov That sounds like a good way forward! Good input! 👍 |
@expez In light of this development I'd suggest for you to just remove the hotloading support, which will also solve the problem with getting out a new snapshot and we'll revisit this a couple of months from now when clojure-emacs/cider-nrepl#540 is live and we're running happily on the modern nREPL. |
@bbatsov Yeah, that makes sense to me too. |
I think we can close this one. No need to keep open stale PRs forever. |
fixes #206
this allows hotloading in java10, but it probably requires some more testing.