Fix large number of open files from java parser #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a file manager that backs each DocletEnvironment. As part of
parsing the docs, a jars from the classpath are loaded into it. If you
do not close the file manager after you're done with the
DocletEnvironment, they're held onto forever.
Especially due to the
(future)
in orchard.java which parses the docsfor a bunch of classes, this can quickly snowball into the maximum file
limit being reached. It won't fail in the foreground, but further
attempts to open files will fail.
Closing the file manager is recommended in
https://docs.oracle.com/en/java/javase/11/docs/api/java.compiler/javax/tools/JavaCompiler.html
I attempted to reuse a file manager, but it didn't seem to work
correctly between invocations. Presumably because of compiler state or
something.